Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rejection emails #678

Closed
wants to merge 9 commits into from
Closed

Conversation

lucao2018
Copy link
Contributor

Closes #665

gfting and others added 8 commits June 30, 2020 14:32
* Centralize custom strings in client to strings.json

* Make redirect on unsubscribe templatized

* Fix typo in Announcement

* Rename application_status.svg
* Modify application to prepare for VH2020 summer

* Fix minor bugs and update title string

* Add 2024 as grad year option

* Add button on login screen to redirect to summer.vh website (#631)

* add button linking to summervh

* Fix linting and testing errors

Co-authored-by: Gabriel Ting <[email protected]>

* Make summer link open in new tab

* Update email templates for vh summer edition 2020 (#636)

* update application deadline (#641)

* add summer hackathon waiver (#639)

* add summer hackathon waiver

* Add waiver as required field

Co-authored-by: Gabriel Ting <[email protected]>

* Add sentence about hackathon waiver (#643)

* add sentence about hackathon waiver

* Change waiver wording

* Change waiver wording

Co-authored-by: Gabriel Ting <[email protected]>

Co-authored-by: Baibhav Vatsa <[email protected]>
Copy link
Member

@BaibhaVatsa BaibhaVatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Automatically added, do not manually add label Sep 1, 2020
@gfting
Copy link
Member

gfting commented Sep 2, 2020

The PR looks good, but I would like the following to happen:

  • Do some testing on the vaken-staging deployment. I think this would be valuable to make sure it's fine.
  • Blocker: staging is currently broken, I haven't had time to investigate myself.

@@ -318,6 +318,7 @@ export const resolvers: CustomResolvers<Context> = {
throw new UserInputError(`user ${id} (${value}) error: ${JSON.stringify(err)}`);

if (status === ApplicationStatus.Accepted) sendStatusEmail(value, ApplicationStatus.Accepted);
if (status === ApplicationStatus.Rejected) sendStatusEmail(value, ApplicationStatus.Rejected);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this should never be a problem, I think that this should be an else if

@BaibhaVatsa
Copy link
Member

iirc @lucao2018 tested this locally and it was working

@codeclimate
Copy link

codeclimate bot commented Sep 9, 2020

Code Climate has analyzed commit 6b1ffec and detected 0 issues on this pull request.

View more on Code Climate.

@leonm1 leonm1 changed the base branch from staging to main October 24, 2020 21:34
@leonm1
Copy link
Member

leonm1 commented Dec 30, 2020

/rebase

@leonm1
Copy link
Member

leonm1 commented Jan 13, 2021

Looks like this is already in main, likely through the event branch.

@leonm1 leonm1 closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Automatically added, do not manually add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capability to send rejection email from Vaken
4 participants