Add support for rejection emails #678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Centralize custom strings in client to strings.json * Make redirect on unsubscribe templatized * Fix typo in Announcement * Rename application_status.svg
* Modify application to prepare for VH2020 summer * Fix minor bugs and update title string * Add 2024 as grad year option * Add button on login screen to redirect to summer.vh website (#631) * add button linking to summervh * Fix linting and testing errors Co-authored-by: Gabriel Ting <[email protected]> * Make summer link open in new tab * Update email templates for vh summer edition 2020 (#636) * update application deadline (#641) * add summer hackathon waiver (#639) * add summer hackathon waiver * Add waiver as required field Co-authored-by: Gabriel Ting <[email protected]> * Add sentence about hackathon waiver (#643) * add sentence about hackathon waiver * Change waiver wording * Change waiver wording Co-authored-by: Gabriel Ting <[email protected]> Co-authored-by: Baibhav Vatsa <[email protected]>
|
The PR looks good, but I would like the following to happen:
|
gfting
reviewed
Sep 2, 2020
src/server/resolvers/index.ts
Outdated
| @@ -318,6 +318,7 @@ export const resolvers: CustomResolvers<Context> = { | |||
| throw new UserInputError(`user ${id} (${value}) error: ${JSON.stringify(err)}`); | |||
|
|
|||
| if (status === ApplicationStatus.Accepted) sendStatusEmail(value, ApplicationStatus.Accepted); | |||
| if (status === ApplicationStatus.Rejected) sendStatusEmail(value, ApplicationStatus.Rejected); | |||
There was a problem hiding this comment.
Even though this should never be a problem, I think that this should be an else if
|
iirc @lucao2018 tested this locally and it was working |
|
Code Climate has analyzed commit 6b1ffec and detected 0 issues on this pull request. View more on Code Climate. |
leonm1
approved these changes
Oct 24, 2020
|
/rebase |
|
Looks like this is already in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #665