Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .NET Trimming #40

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Add support for .NET Trimming #40

wants to merge 8 commits into from

Conversation

yaakov-h
Copy link
Member

Resolves #39.

Work-in-progress. It looks about right to me but I haven't put it through its paces just yet to see if it (a) still works, and (b) trims the appropriate stuff.

@yaakov-h
Copy link
Member Author

is it worth screwing around with MergeWith or should I just upload the coverage for the latest target (in this PR, net5.0)?

@xPaw
Copy link
Member

xPaw commented Sep 18, 2021

Latest target is fine by me. The reason I omitted version from folder is so that actions don't need to be updated when target is changed.

@yaakov-h
Copy link
Member Author

now I just need to figure out what the actual filepaths are 😅

@xPaw
Copy link
Member

xPaw commented Sep 18, 2021

home/runner/work/ValveKeyValue/ValveKeyValue/ValveKeyValue/ValveKeyValue/bin/Release/netstandard2.1/ValveKeyValue.dll

You want to add Release/net5.0

@yaakov-h
Copy link
Member Author

405 not allowed? 😕

@xPaw
Copy link
Member

xPaw commented Sep 20, 2021

It's broken in master too 🤷

@yaakov-h
Copy link
Member Author

that's better

@xPaw
Copy link
Member

xPaw commented Sep 22, 2021

Release workflow probably needs path update too.

Merge whenever you want.

@xPaw
Copy link
Member

xPaw commented Nov 25, 2021

Shall we target net6 with this instead? It's LTS.

@yaakov-h
Copy link
Member Author

Sure.

I'm thinking it might also be worth redoing this from scratch with the latest linker and analyzers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .NET trimming
2 participants