-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#137 [FEAT]: Permission management optimizations #138
Merged
IosBonaldi
merged 14 commits into
main
from
137-feat-permission-management-optimizations
Feb 23, 2025
Merged
#137 [FEAT]: Permission management optimizations #138
IosBonaldi
merged 14 commits into
main
from
137-feat-permission-management-optimizations
Feb 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and enhance classroom and application models
…ps and guest users
…e guest users and set default approval status
…authorization checks for user roles
…llow answer approval
…thorization checks for answer visibility
…cess permissions
…le endpoints responses
…nd include apply permissions
… enhance protocol visibility filtering
c36c795
to
45900d7
Compare
…ensure proper role validation
…d adjust sensitive field filtering
YuriTobias
approved these changes
Feb 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
prisma/schema.prisma
file and thesrc/controllers/applicationAnswerController.ts
file to add new features and improve functionality. The most important changes include adding new user roles and visibility modes, updating theApplicationAnswer
model, introducing a newCoordinate
model, and enhancing the application answer controller with additional roles and actions.Schema updates:
GUEST
toUserRole
enum andAUTHENTICATED
toVisibilityMode
enum inprisma/schema.prisma
. [1] [2]ApplicationAnswer
model to includeapproved
field and replacedaddress
relation withcoordinate
relation.Coordinate
model to store latitude and longitude information.Controller enhancements:
getApplicationUserRoles
,getApplicationAnswerUserRoles
, andgetApplicationAnswerActions
to manage user roles and actions for application answers insrc/controllers/applicationAnswerController.ts
. [1] [2]checkAuthorization
function to use new role-checking functions and added support forapprove
action.createApplicationAnswer
andupdateApplicationAnswer
functions to handlecoordinate
data and filter sensitive fields from the response. [1] [2] [3] [4] [5]