chore: electronのカレントディレクトリの変更のロジックを共通化 #2570
Open
+13
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Hiroshiba
commented
Feb 26, 2025
Comment on lines
197
to
199
| initializeEngineInfoManager({ | ||
| defaultEngineDir: appDirPath, | ||
| appDirPath, | ||
| vvppEngineDir, |
There was a problem hiding this comment.
引数defaultEngineDirにはappDirPathを渡してたのですが、ややこしいからもうappDirPathのまま受け取るようにしてみました。
VOICEVOXの場合、「デフォルトエンジンディレクトリ」の場所はどっちかというと{appDirPath}/vv-engineだよなぁと思ったので。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の解決として実装してみました。
相対パスを利用している場所がデフォルトエンジン以外に無いか少し不安。。。
pathの
resolveやprocessのspawnやexecで調べた感じ大丈夫そうだけど。。readFileで相対パスを使ってるのとかない･･･かなぁ。関連 Issue
resolve #2568
その他
先に↓が必要です。