Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 7zやtyposのダウンロードをリトライする #2566

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hiroshiba
Copy link
Member

内容

downloadTypos内にあるfetchをリトライするようにしてみました。

https://github.com/VOICEVOX/voicevox/actions/runs/13535774481/job/37827107361
で落ちてmerge-queueが失敗したので実装してみました。

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner February 26, 2025 03:54
@Hiroshiba Hiroshiba requested review from sevenc-nanashi and Copilot and removed request for sevenc-nanashi February 26, 2025 03:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

tools/helper.ts:11

  • [nitpick] The loop using 'retries - 1' might be confusing and could potentially lead to off-by-one errors if 'retries' is set to 0 or 1. Consider iterating exactly 'retries' times and moving the delay logic inside the loop to handle all attempts uniformly.
for (let i = 0; i < retries - 1; i++) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant