refactor: installVvppEngineをthrowする形に変更 #2557
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…--installVvppEngineをthrowする形に変更
…--installVvppEngineをthrowする形に変更
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
installVvppEngine内でダイアログを表示していて再利用できなかったので、throwしてキャッチしてダイアログを表示する形に変えてみました。
ついでに
installVvppEngineWithWarning関数内で早期リターンしてない事に気づいたので直しておきました。関連 Issue
スクリーンショット・動画など
その他
の続きになります。
↑からの差分はこのURLで見れるはず。
https://github.com/VOICEVOX/voicevox/pull/2557/files/2298e9f19afcf5a0788763f7e75a0b4411dd38c4..HEAD