From a884889619df8e9cd17aa8684b8156883429d954 Mon Sep 17 00:00:00 2001 From: Rachel Marconi Date: Tue, 7 Jan 2025 11:06:10 -0500 Subject: [PATCH 1/4] add story or data tool home page link to eyebrow --- src/lib/Headline/Headline.svelte | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/src/lib/Headline/Headline.svelte b/src/lib/Headline/Headline.svelte index 62c1a28..d827a81 100644 --- a/src/lib/Headline/Headline.svelte +++ b/src/lib/Headline/Headline.svelte @@ -15,7 +15,7 @@ export let description = null; /** - * Optional eyebrow to be displayed above the headline. + * Optional eyebrow to be displayed above the headline; determines eyebrow link. * @type {string | null} */ export let eyebrow = null; @@ -55,32 +55,34 @@
{#if $$slots.eyebrow} {:else if eyebrow} -

{eyebrow}

+ {#if eyebrow.toLowerCase() == "data tool"} +

{eyebrow}

+ {:else if eyebrow.toLowerCase() == "story"} +

{eyebrow}

+ {:else} +

{eyebrow}

+ {/if} {/if} {#if $$slots.headline} {:else}

{headline}

{/if} {#if $$slots.description} {:else if description}

{description}

{/if} {#if $$slots.date} {:else if date}

@@ -91,8 +93,6 @@

{/if}
@@ -148,4 +148,8 @@ font-size: var(--font-size-small); text-transform: uppercase; } + .headline-wrap p.headline-eyebrow:hover { + text-decoration: underline; + cursor: pointer; + } From fd6957f25959bb124caaaccdd20030cd17d966ef Mon Sep 17 00:00:00 2001 From: Rachel Marconi <56045588+rachelmarconi@users.noreply.github.com> Date: Tue, 7 Jan 2025 11:09:21 -0500 Subject: [PATCH 2/4] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2c6f471..61e3c6f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # @UrbanInstitute/dataviz-components Changelog ## Next +- Patch: Headline eyebrows in Drupal include a link to the Story or Data tool homepage; tweaked Headline component to do the same. - Fix: CSS Theme variable --color-green was #ffb748, which is a kind of yellow. Changed to match style guide. ## v0.12.4 From f85da18d48bbde8ea211207093a9ad40fef30606 Mon Sep 17 00:00:00 2001 From: Rachel Marconi <56045588+rachelmarconi@users.noreply.github.com> Date: Tue, 7 Jan 2025 11:24:29 -0500 Subject: [PATCH 3/4] no semis in jsdoc --- src/lib/Headline/Headline.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/Headline/Headline.svelte b/src/lib/Headline/Headline.svelte index d827a81..c4c2170 100644 --- a/src/lib/Headline/Headline.svelte +++ b/src/lib/Headline/Headline.svelte @@ -15,7 +15,7 @@ export let description = null; /** - * Optional eyebrow to be displayed above the headline; determines eyebrow link. + * Optional eyebrow to be displayed above the headline. Determines eyebrow link. * @type {string | null} */ export let eyebrow = null; From 40961fbf36cd24881f8a3a41ab9409300d35dc6b Mon Sep 17 00:00:00 2001 From: Rachel Marconi Date: Tue, 7 Jan 2025 11:29:36 -0500 Subject: [PATCH 4/4] fix comments --- src/lib/Headline/Headline.svelte | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/lib/Headline/Headline.svelte b/src/lib/Headline/Headline.svelte index c4c2170..1d3426b 100644 --- a/src/lib/Headline/Headline.svelte +++ b/src/lib/Headline/Headline.svelte @@ -55,6 +55,8 @@
{#if $$slots.eyebrow} {:else if eyebrow} {#if eyebrow.toLowerCase() == "data tool"} @@ -71,18 +73,24 @@ {/if} {#if $$slots.headline} {:else}

{headline}

{/if} {#if $$slots.description} {:else if description}

{description}

{/if} {#if $$slots.date} {:else if date}

@@ -93,6 +101,8 @@

{/if}