Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use datatable column descriptions from server-side #215

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

b-rowan
Copy link
Contributor

@b-rowan b-rowan commented Nov 26, 2024

A continuation of the server-side column handling introduced in #170, handling for the devices page is now slightly cleaner, and handling has been introduced for the remaining pages.

@UpstreamData UpstreamData force-pushed the dt_columns_from_server branch 3 times, most recently from df82c96 to 896b6b6 Compare November 26, 2024 18:06
Copy link
Collaborator

@tsagadar tsagadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this functionality unified in all screens. It comes with an additional request to show the UI (vs. embedding a column config already during template generation) but this should not really matter.

goosebit/ui/static/js/software.js Show resolved Hide resolved
@UpstreamData UpstreamData force-pushed the dt_columns_from_server branch from 896b6b6 to 600920f Compare December 2, 2024 19:57
@b-rowan b-rowan force-pushed the dt_columns_from_server branch from 600920f to 7acae19 Compare December 3, 2024 14:42
@b-rowan b-rowan force-pushed the dt_columns_from_server branch from 7acae19 to 29350a7 Compare December 3, 2024 16:32
@b-rowan b-rowan merged commit 9717748 into master Dec 3, 2024
6 checks passed
@b-rowan b-rowan deleted the dt_columns_from_server branch December 3, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants