File moves may fail with OSError

[b-rowan]

goosebit/goosebit/updates/__init__.py

Line 50 in f7a0ce7

await temp_file.rename(path)

May fail with OSError: [Errno 18] Invalid cross-device link: '/tmp/tmp0egb8ja1' -> 'goosebit/artifacts if target is on a different filesystem.

[jameshilliard]

hmm, thinking we maybe need to put the tempfile in the artifacts directory somehow?

[b-rowan]

Fixed in #132 by using this instead, might as well have a separate PR -

        # basically os.rename, but sync and async versions of that break across filesystems
        async with await open_file(temp_file, "rb") as temp_file:
            async with await open_file(path, "wb") as file:
                while True:
                    chunk = await temp_file.read(1024 * 1024)
                    if not chunk:
                        break
                    await file.write(chunk)

[jameshilliard]

Fixed in #132 by using this instead, might as well have a separate PR -

Maybe, should have this just as a fallback on failure of the rename?

[b-rowan]

Fixed in #132 by using this instead, might as well have a separate PR -

Maybe, should have this just as a fallback on failure of the rename?

Works for me, just catch OSError