Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tests for bootstrapping priority #89

Open
sighphyre opened this issue Feb 11, 2022 · 1 comment
Open

Extend tests for bootstrapping priority #89

sighphyre opened this issue Feb 11, 2022 · 1 comment
Labels
pinned Should not go stale

Comments

@sighphyre
Copy link
Member

Right now the order of bootstrapping options is codified in source code but not through tests/specs. We should lay down some tests to ensure that the order of bootstrapping selector is defined.

Currently the order of priority is:

  • Data object is highest priority
  • Then the closure
  • Then the file bootstrapper
  • Then the url bootstrapper

This should be fixed in place with a test so that it isn't accidentally changed in future

@stale
Copy link

stale bot commented Nov 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 2, 2022
@rarruda rarruda added the pinned Should not go stale label Nov 2, 2022
@stale stale bot removed the stale label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Should not go stale
Projects
None yet
Development

No branches or pull requests

2 participants