Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unleash client stops fetching #615

Closed
olehfitsyk opened this issue May 21, 2024 · 1 comment · Fixed by #616
Closed

Unleash client stops fetching #615

olehfitsyk opened this issue May 21, 2024 · 1 comment · Fixed by #616
Assignees
Labels

Comments

@olehfitsyk
Copy link

Describe the bug

We encountered an issue with Unleash Proxy a few times when it seemed that it stopped getting any updates from Unleash. It was caused by the update in unleash-client release 5.2 because it stops fetching Unleash configuration when it encounters status codes 401, 403 or 404. Please see handleErrorCases function. I agree that it seems like a configuration issue, but in my opinion, after the successful initial fetch, it doesn't make sense to just stop pulling updates from Unleash in case a single 404 is encountered.

Steps to reproduce the bug

No response

Expected behavior

No response

Logs, error output, etc.

No response

Screenshots

No response

Additional context

No response

Unleash version

No response

Subscription type

None

Hosting type

None

SDK information (language and version)

No response

@olehfitsyk olehfitsyk added the bug label May 21, 2024
@olehfitsyk olehfitsyk changed the title Unleash client stops polling Unleash client stops fetching May 21, 2024
@HenrikBacher
Copy link
Contributor

Issue seems to have been introduced with #537 I think it would make sense to extend the retry logic to also cover 404 errors

HenrikBacher added a commit to HenrikBacher/unleash-client-node that referenced this issue May 22, 2024
@chriswk chriswk self-assigned this May 22, 2024
chriswk pushed a commit that referenced this issue May 22, 2024
* Fixes Unleash client stops fetching #615

* Update repository test for 404 case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants