Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results page broken after updating counter feedback #1315

Closed
HRemonen opened this issue Jun 6, 2024 · 2 comments
Closed

Results page broken after updating counter feedback #1315

HRemonen opened this issue Jun 6, 2024 · 2 comments
Assignees
Labels
bug norppa is broken

Comments

@HRemonen
Copy link
Contributor

HRemonen commented Jun 6, 2024

When a counter feedback has been given and the teacher goes to edit the counter feedback the feedback target loses its student count completely which results in the following behaviour:

Image

How to repro

  • Go to a feedback target which has counter feedback
  • Check the results page that the results are shown
  • Go to edit the counter feedback and save the new new feedback
  • Go to the results page
  • Reload the page and everything works again

How to fix

  • Probably something to do with the cache so check if the queries are invalidated after counter feedback
  • Perhaps it will be more stable after the feedback count and student counts are fetched from the summary object rather than the feedback target object. See Remove the denormalized feedbackCount from FBT #1227 for further information.
@HRemonen HRemonen self-assigned this Jun 6, 2024
@HRemonen HRemonen converted this from a draft issue Jun 6, 2024
@HRemonen HRemonen added the bug norppa is broken label Jun 6, 2024
@HRemonen HRemonen removed their assignment Jun 6, 2024
@tfhuhtal tfhuhtal self-assigned this Nov 4, 2024
@tfhuhtal
Copy link
Contributor

tfhuhtal commented Nov 4, 2024

Image

@tfhuhtal
Copy link
Contributor

tfhuhtal commented Nov 4, 2024

Problem is isolated to backend!

@tfhuhtal tfhuhtal closed this as completed Nov 7, 2024
@github-project-automation github-project-automation bot moved this from deployed in production to checked by BIGBOSS in Norppa Backlog Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug norppa is broken
Projects
Archived in project
Development

No branches or pull requests

2 participants