Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links should be identified correctly #1241

Closed
HRemonen opened this issue Mar 15, 2024 · 3 comments
Closed

Links should be identified correctly #1241

HRemonen opened this issue Mar 15, 2024 · 3 comments
Assignees
Labels

Comments

@HRemonen
Copy link
Contributor

HRemonen commented Mar 15, 2024

In some places links are styled as buttons or chips which breaks success criterion 1.4.1.
Links must be identified by underlines or some other non-color visual distinction.

While some links may be visually evident from page design and context, such as navigational links, links within text are often visually understood only from their own display attributes. Removing the underline and leaving only the color difference for such links would be a failure because there would be no other visual indication (besides color) that it is a link.

Also links must be presented with an underline on hover. See also requirements for adequate color contrast ratios:
https://webaim.org/resources/linkcontrastchecker/

@Veikkosuhonen
Copy link
Member

Good one

@HRemonen HRemonen removed their assignment Mar 15, 2024
@HRemonen
Copy link
Contributor Author

HRemonen commented Mar 15, 2024

Good one

We'll see when the time comes for this one tho :D There's a lot of pages and links to go through

@Veikkosuhonen
Copy link
Member

Start from https://github.com/UniversityOfHelsinkiCS/palaute/blob/master/src/client/components/common/LinkButton.js. That should fix most of the issues.

@HRemonen HRemonen moved this to Priority in Norppa Backlog May 27, 2024
@HRemonen HRemonen added the good first issue Good for newcomers label Oct 15, 2024
@HRemonen HRemonen assigned HRemonen and tfhuhtal and unassigned HRemonen Oct 17, 2024
@github-project-automation github-project-automation bot moved this from In progress to checked by BIGBOSS in Norppa Backlog Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants