Replies: 5 comments 8 replies
-
I've noticed we use spaces for indentation 💀. We really should use tabs, while we decide what to do |
Beta Was this translation helpful? Give feedback.
-
Sounds good for a major future release (e.g. 2.0.0). |
Beta Was this translation helpful? Give feedback.
-
1 file per OEM seems quite reasonable. Question about carriers: don't they also sometimes put stuff on the phones (that's not the case for my country, but idk how it is in US / elsewhere). In that case, perhaps also 1 file per carrier, then you choose the phone+carrier combo. |
Beta Was this translation helpful? Give feedback.
-
Also, how about making dependencies, labels and neededBy optional? Would save some space by those apps which pnly have empty arrays there. |
Beta Was this translation helpful? Give feedback.
-
Ok, here's a more exotic idea. What if these files also double as a knowledge-base? We create a separate repo with markdown files for each category. uad pulls these markdown files, parses them for use. That way, even a passer by will be able to see descriptions of the apps. Also see: dnscrypt-proxy2 which uses markdown files for public resolvers. |
Beta Was this translation helpful? Give feedback.
-
Intro
As of now,
uad_lists
is ~1.4MB.#608 (reply in thread)
Some text editors may have performance problems when loading the file (but let's be honest, those editors are poorly optimized).
Potential solutions
Format
On #516, I proposed migrating from JSON to some other standard format. But maybe we could benefit from a specially-designed format. I could write a parser that not only validates syntax, but also the values of the fields (similar to #536)
I managed to reduce the List to ~0.9MB by:
For reference, compressing the "non-minified" file with
yields a ~0.19MB file. While the minified one compresses to ~0.18MB
For simplicity, we could also choose CSV
Split
Aside from modifying the file, we could also break it in multiple files, for better organization.
I would propose 1 file for each major OEM, as that would allow UAD-ng to avoid loading all lists, iff 1-or-more devices from the same OEM are connected. This can also serve as a network optimization, as only 1 OEM list needs to be updated at a time.
#608 (reply in thread)
See also
uad_lists
to a separate repository #612 / Move `uad_lists` to a separate repository #646Beta Was this translation helpful? Give feedback.
All reactions