Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I feel like something wrong with agent's observations #10

Open
c0mb1ne opened this issue Apr 9, 2023 · 0 comments
Open

I feel like something wrong with agent's observations #10

c0mb1ne opened this issue Apr 9, 2023 · 0 comments

Comments

@c0mb1ne
Copy link

c0mb1ne commented Apr 9, 2023

I was inspecting what kind of observations agents gets, and found that in this line of code, we trying to normalize the number remaining enemies to add them to observation. And this variable never being used in this code anymore.

var portionOfEnemiesRemaining = (float)numEnemiesRemaining / (float)opponentsList.Count;

but here we just add the flat number of remaining enemies, which is kinda goes against ml-agents guidelines about normalizing observation for better perfomance.

sensor.AddObservation(numEnemiesRemaining);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant