Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to exchange in valid way #700

Open
benys opened this issue Sep 22, 2024 · 4 comments
Open

How to exchange in valid way #700

benys opened this issue Sep 22, 2024 · 4 comments
Assignees
Labels
question Further information is requested
Milestone

Comments

@benys
Copy link

benys commented Sep 22, 2024

Dear OSDM Team,

I found at https://osdm.io/spec/state-models/ diagram: Exchange diagram

please confirm that my way is ok:
a) passenger search exchange offers by: /bookings/{bookingId}/exchange-offers [don't pass detailed passanger, only anonimousPassengers]
b) selects best offer and create exchange operation by /bookings/{bookingId}/exchange-operations -> creates exchangeOperation [don't pass detailed passanger, only anonimousPassengers]
c) confirms exchange operation by /bookings/{bookingId}/fulfillments (bookingId is exchangeOperationId)

but I have question? how and when passenger can define purcharser details and passenger details?
for example: passenger wants to add new person / or replace persons..

Kamil

@jspetrak jspetrak added this to the 3.4.0 milestone Sep 23, 2024
@jspetrak jspetrak added the question Further information is requested label Sep 23, 2024
@jspetrak jspetrak moved this to To do in OSDM Specification Sep 23, 2024
@jspetrak
Copy link
Collaborator

In the step A you defined new number and parameters of passengers, so you can specify the same passengers as originally booked, or completely different ages, reduction cards, ...

The exchange is performed on top of the original booking so there is currently no mean to change purchaser. That is retained as originally submitted for the booking.

@jspetrak
Copy link
Collaborator

Also, we are going to update the exchange diagram, see #691

@jspetrak jspetrak moved this from To do to In progress in OSDM Specification Sep 23, 2024
@benys
Copy link
Author

benys commented Sep 24, 2024

I understand but:

  1. to confirm exchange have I execute normal booking fulfillment?
  2. to set new first name and last name I have to use passenger API?(After creating exchange operation)?
    From my perspective is no consistent. During creating exchange operating we should pass passenger details same as creating normal booking.

@CGantert345
Copy link
Contributor

1.: described in: https://github.com/UnionInternationalCheminsdeFer/OSDM/wiki/meeting-minutes-2022#2022-12-16-meeting
this will be added to the documention

  1. Change of name would have to be made via the passenger API, but change of name might not be allowed or restricted by the provider due to tariff conditions.

@CGantert345 CGantert345 modified the milestones: 3.4.0, 4.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: In progress
Development

No branches or pull requests

3 participants