Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of Pretty Diff published to NPM #114

Open
prettydiff opened this issue Dec 28, 2018 · 6 comments
Open

Latest version of Pretty Diff published to NPM #114

prettydiff opened this issue Dec 28, 2018 · 6 comments
Assignees

Comments

@prettydiff
Copy link
Collaborator

Published to the old namespace - https://www.npmjs.com/package/prettydiff

The option names have changed to a uniform naming convention. The application is new and completely rewritten from scratch in TypeScript. I will be looking at how to integrate this back into the project.

@Glavin001
Copy link
Member

Awesome! 🎉

Pretty Diff version 100

Is it really version 100? I was expecting something like version 3.

@prettydiff
Copy link
Collaborator Author

Yeah, so back when NPM3 was unstable and kept breaking my package I closed out that namespace by pushing the version number up to 99. This was before I created the prettydiff2 namespace. The only way to use that original namespace is to push the version number above major version 99.

@Glavin001
Copy link
Member

Glavin001 commented Dec 29, 2018

I thought you could publish major versions behind the highest major version 🤔... this is how two different major releases could have bug fixes published in a respective patch release. The only thing you should not be able to do is publish with the same version.

@prettydiff
Copy link
Collaborator Author

In semver major versions should be reserved for breaking changes. This update is certainly a breaking change as I changed the API. My major version options with NPM are to publish version 100 in the prettydiff package name, version 3 in the prettydiff2 package name, or create a new package name like prettydiff3

@Glavin001
Copy link
Member

In semver major versions should be reserved for breaking changes.

Yes, of course.

I closed out that namespace by pushing the version number up to 99.

Was the version 99 published a real version of Pretty Diff at all? Sounded like it was simply a way close out the namespace -- although I do not understand why it was necessary 🤷‍♂️ . I figured you could unpublish these fake v99 releases and create v3 as the new highest major, but I digress.

or create a new package name like prettydiff3

👎

version 3 in the prettydiff2 package name,

I think publishing 3.0.0 to prettydiff2 package sounds acceptable then, such that the version number on npm actually reflects the Pretty Diff version number, which I presume is v3?

@prettydiff
Copy link
Collaborator Author

I was not aware that versions could be unpublished. I know that used to be possible, but I thought NPM eliminated that for security reasons. Yeah, 3.0.2 would be the most accurate version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants