Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facecount in MeshBuilder.addIndices vs MeshBuilder.setIndices #190

Open
fieldOfView opened this issue Nov 29, 2016 · 0 comments
Open

Facecount in MeshBuilder.addIndices vs MeshBuilder.setIndices #190

fieldOfView opened this issue Nov 29, 2016 · 0 comments
Labels
Type: Bug The code does not produce the intended behavior.

Comments

@fieldOfView
Copy link
Contributor

MeshBuilder.addIndices vs MeshBuilder.setIndices both set the self._indices to the input indices argument (so I am guessing they expect the same input), but they calculate the new self._face_count differently:
https://github.com/Ultimaker/Uranium/blob/master/UM/Mesh/MeshBuilder.py#L124
https://github.com/Ultimaker/Uranium/blob/master/UM/Mesh/MeshBuilder.py#L352

When using addIndices the resulting facecount seems to be 3 times that of when using setIndices. Either one of them is doing it wrong, or some documentation is needed to explain why there is a difference.
@Ghostkeeper Ghostkeeper added the Type: Bug The code does not produce the intended behavior. label Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug The code does not produce the intended behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fieldOfView @Ghostkeeper