-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaling-to-fit may suffer from float rounding artifacts #159
Comments
sevaa
changed the title
Scaling to fit subject to float rounding artifacts
Scaling-to-fit may suffer from float rounding artifacts
Aug 12, 2016
Hmm, this one again. Our internal issue tracker says this was solved back in April. Must be a regression. We have a bugfix planned for 2.4 and a rewrite for 3.1. I'll add this bug to be planned in as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uranium has logic to scale loaded meshes to fit into the printable area (in UM/Mesh/ReadMeshJob.run(), line 74 and below). Because of floating point math being inherently imprecise, the scaled mesh may still not fit into the printable area.
Please introduce a rounding tolerance factor to account for that. Forcibly multiply the calculated scaling factor by 0.99999 or something of that nature.
The text was updated successfully, but these errors were encountered: