Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URL format for PR comment #31

Open
gadkins opened this issue Oct 17, 2022 · 7 comments
Open

Update URL format for PR comment #31

gadkins opened this issue Oct 17, 2022 · 7 comments
Assignees
@axisofentropy
Projects
Working Project Board

Comments

@gadkins
Copy link
Member

gadkins commented Oct 17, 2022

Uffizzi https://github.com/UffizziCloud/uffizzi_platform/issues/281, of the format:

https://app.uffizzi.com/github.com/waveywaves/backstage/pull/4

This URL will redirect to a URL such as:
deployment-6562-foo-bar-x0vlpg.app.uffizzi.com

We should update the comment that gets posted to the PR with the predictable URL format.
@gadkins gadkins created this issue from a note in Working Project Board (Ready for Development) Oct 17, 2022
@gadkins
Copy link
Member Author

gadkins commented Oct 17, 2022

This should be updated in the reusable workflow

@gadkins
Copy link
Member Author

gadkins commented Oct 18, 2022 •
edited

@axisofentropy Can we format the comment with markdown to improve readability? For example, use a heading, markdown links, and emojis. Also can we add a link to our repo to learn more?

Uffizzi Preview Environment

☁️ https://app.uffizzi.com/github.com/example/example-app/pull/215

📄 View application logs

   
What is Uffizzi? Learn more

@axisofentropy
Copy link
Member

image
image

@gadkins gadkins moved this from Ready for Development to Code Review in Working Project Board Oct 20, 2022
@gadkins gadkins moved this from Code Review to In QA in Working Project Board Oct 20, 2022
@axisofentropy axisofentropy mentioned this issue Oct 21, 2022
Merged
@NealArw
Copy link

NealArw commented Oct 24, 2022 •
edited

👉 1.

  • I set up in my workflow server: https://deployment-6716-ufzi-on-ufzi-cp-internal-x0vlpg.app.uffizzi.com/
  • Workflow file: https://github.com/DbpUffizziTest/quickstart/blob/try-uffizzi/.github/workflows/uffizzi-preview.yaml
  • Create PR in my repo: https://github.com/DbpUffizziTest/quickstart/pull/16

Result: In PR was created comment with the link for production env:
image

@NealArw
Copy link

NealArw commented Oct 24, 2022

@moklidia

Result: Fix the link in the comment (change prod env to UonU env) and try to open the link. Deployment-1 opened (with 404 error).
Correct link:

https://deployment-6716-ufzi-on-ufzi-cp-internal-x0vlpg.app.uffizzi.com/github.com/DbpUffizziTest/quickstart/pull/16

@NealArw NealArw moved this from In QA to Ready for Development in Working Project Board Oct 24, 2022
axisofentropy added a commit that referenced this issue Oct 24, 2022
@axisofentropy
Don't assume production server URL. #31
58704a2
@axisofentropy
Copy link
Member

Correct link:

https://deployment-6716-ufzi-on-ufzi-cp-internal-x0vlpg.app.uffizzi.com/github.com/DbpUffizziTest/quickstart/pull/16

Thanks for noticing this. I've updated the deprecate_set-output branch. Use it for testing. 58704a2 and #35

axisofentropy added a commit that referenced this issue Oct 27, 2022
@axisofentropy
Deprecate set-output (#35) and Update Comments with Predictable URL…
f6483ab 
…'s (#31)

* Predict Deployment URL and post comment before deployment. #31

* Change some `set-output` per GitHub https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

* Add option to specify git reference for use within `workflow_run` workflows.
@axisofentropy axisofentropy moved this from Ready for Development to Released in Working Project Board Oct 27, 2022
@antlu
Copy link

antlu commented Oct 28, 2022

There is an extra slash after the hostname. But the URL is still valid.
image

@moklidia moklidia removed the returned label Oct 31, 2022
@NealArw NealArw moved this from Released to Verified on Production in Working Project Board Oct 31, 2022
@moklidia moklidia moved this from Verified on Production to Closed in Working Project Board Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axisofentropy axisofentropy

Labels
None yet
Projects
Working Project Board
Closed
Milestone
No milestone
Development

No branches or pull requests
5 participants
@axisofentropy @gadkins @antlu @moklidia @NealArw