Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to GitHub actions #157

Open
knoiva-indecon opened this issue Mar 7, 2024 · 2 comments
Open

Modifications to GitHub actions #157

knoiva-indecon opened this issue Mar 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request maintenance testing Related to FrEDI tests

Comments

@knoiva-indecon
Copy link
Collaborator

  1. Issue with Action Test FrEDI Package.
  • GitHub action to create report figures no longer working as of Commit State level add new state-level sectors #155, after adding state-level capability for a batch of sectors (roads, coastal properties, vibrio, CIL agriculture, valley fever)
  • Getting error The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled. (e.g., see Action #:)
  • Likely that the addition of the new state-level sectors has led to an issue where the resources consumed in the process exceeded the limits. Will need to break into multiple steps (maybe create and save data and then create figures? Or, at least remove intermediate objects and only load as needed).
  1. Add additional report figures.
  2. Consider adding the test to create a dashboard to compare results to those from a dedicated branch of FrEDI.
@knoiva-indecon knoiva-indecon added enhancement New feature or request maintenance labels Mar 7, 2024
@knoiva-indecon knoiva-indecon self-assigned this Mar 7, 2024
@knoiva-indecon knoiva-indecon added bug Something isn't working testing Related to FrEDI tests labels Mar 7, 2024
@knoiva-indecon
Copy link
Collaborator Author

Tests still work locally. Will separate the action into multiple steps in a future update.

@knoiva-indecon
Copy link
Collaborator Author

Addressed with merge of pull request #167 or pull request #168, after splitting the creation of report figures (the testing workflow) into multiple steps. However, after extending max year to 2100, running into the same issue again, where the creation of appendix figures times out.

Need to look into splitting the appendix figures into multiple steps, or other ways to increase the efficiency of the functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request maintenance testing Related to FrEDI tests
Projects
None yet
Development

No branches or pull requests

1 participant