Skip to content

Commit e16b2f0

Browse files
Merge pull request #80 from UIUCLibrary/fix-ci
ci: windows dockerfile used to build Chocolatey can override image
2 parents e11d6c1 + 8d21c42 commit e16b2f0

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

ci/docker/chocolatey_package/Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# escape=`
2-
FROM mcr.microsoft.com/dotnet/framework/sdk:4.8-windowsservercore-ltsc2019
2+
ARG FROM_IMAGE=mcr.microsoft.com/dotnet/framework/sdk:4.8-windowsservercore-ltsc2019
3+
4+
FROM ${FROM_IMAGE}
35
#FROM mcr.microsoft.com/windows/servercore:ltsc2019 as choco_builder
46
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop';"]
57

vars/runJenkinsPipeline.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -763,7 +763,7 @@ def call(){
763763
dockerfile {
764764
filename 'ci/docker/chocolatey_package/Dockerfile'
765765
label 'windows && docker && x86'
766-
additionalBuildArgs '--build-arg CHOCOLATEY_SOURCE'
766+
additionalBuildArgs '--build-arg CHOCOLATEY_SOURCE --build-arg FROM_IMAGE=%DEFAULT_DOCKER_DOTNET_SDK_BASE_IMAGE%'
767767
}
768768
}
769769
steps{
@@ -796,7 +796,7 @@ def call(){
796796
dockerfile {
797797
filename 'ci/docker/chocolatey_package/Dockerfile'
798798
label 'windows && docker && x86'
799-
additionalBuildArgs '--build-arg CHOCOLATEY_SOURCE'
799+
additionalBuildArgs '--build-arg CHOCOLATEY_SOURCE --build-arg FROM_IMAGE=%DEFAULT_DOCKER_DOTNET_SDK_BASE_IMAGE%'
800800
}
801801
}
802802
steps{

0 commit comments

Comments
 (0)