Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Improvements in Docker Agent #950

Open
4 tasks
nrybowski opened this issue May 24, 2023 · 0 comments
Open
4 tasks

Tracking issue: Improvements in Docker Agent #950

nrybowski opened this issue May 24, 2023 · 0 comments
Labels

Comments

@nrybowski
Copy link
Member

This issue tracks the improvements that are expected from a future refactor of the Docker Agent base code.

Must Have

  • create_container() and create_container_student() are quite similar. A common routine must be implemented.
  • Arguments of create_container() and create_container_student() are quite numerous and extending them is quite error prone. They should be absracted in DataClasses.
  • The communication system between the child containers and the parent grading container should leverage the Docker network stack .
  • Improve error handling from the Docker API calls (see create_container() and create_container_student()).

Nice to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant