Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime environments allowing to run as root could provide more capabilities to the containers #939

Open
mpiraux opened this issue Apr 18, 2023 · 2 comments · May be fixed by #949
Open

Comments

@mpiraux
Copy link
Contributor

mpiraux commented Apr 18, 2023

Is your feature request related to a problem? Please describe.
Kata runtime could give more priviledge to the root user in the Docker container. Running IPMininet in a Docker container requires the ability of manipulating network namespaces.

Describe the solution you'd like
When the runtime allows to run as root, pass --cap_add=ALL to the container. Do this here,

response = self._docker.containers.create(

Describe alternatives you've considered
Changing the use of Kata+Docker for virtme or smth else

@mpiraux
Copy link
Contributor Author

mpiraux commented Apr 18, 2023

If this create_container function gets passed the run_as_root argument in some form, then it would be able to add the capabilities just for these runtime environments.

@mpiraux mpiraux changed the title Add the context of the feature request at the beginning of the title, if possible, e.g. [frontend/installer] Runtime environments allowing to run as root could provide more capabilities to the containers Apr 18, 2023
@anthonygego anthonygego self-assigned this Apr 18, 2023
@mpiraux
Copy link
Contributor Author

mpiraux commented Apr 19, 2023

There is an issue with --privileged in Kata v1 which has not been fixed for Docker. Mainly, the host tries to mount devices into the VM and the container, which I don't need but which prevents starting the container. --privileged is required to modify sysctls, which are used by IPMininet. It seems that keeping Kata v1 does not allow to move forward on this issue.

@nrybowski nrybowski linked a pull request May 24, 2023 that will close this issue
8 tasks
@nrybowski nrybowski linked a pull request May 24, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants