Milestone 2 Feedback

[pgysbers]

Writing analysis that uses multiple scripts

Mechanics A

• might be an issue in the htest script when results already exists
  Quality A+
  Accuracy A+
  Reasoning C
• a right-skewed plot has more data on the right (not less)
• your hypothesis test is not well-explained. Need to clearly define the test statistic. Do you have a source for your technique?
• I'm confused by the result: if the true diff is -0.025 then it's absolute value is much greater than your significance threshold and it's far outside the null distribution. This seems like the opposite conclusion to the one you make...
  Viz C
• only include useful EDA, which variables are relevant to your analysis?
• a single number doesn't make a table
• Fig 5, the vertical lines should be a thinner than the
  Writing B
• great introduction and good summary of main points of EDA but I think you should not include the URLs here (that can stay in the README) and reduce the amount of raw data you insert (Table 1), stick to a summary sentence. The data dictionary should be Table 1
• use consistent language: "let's load the data" is more appropriate for an EDA notebook, "And I am including it for your convenience:" is directed at a specific person, try to write more generally

Version control and submission expectations

Mechanics A+

Project organization and documentation expectations

Mechanics A+
Writing A

• you can rephrase the README to what you have done (not what you plan to do)
  Reasoning A+
• clear usage and dependencies

Submission expectations

Mechanics A+

[stevenleung2018]

only include useful EDA, which variables are relevant to your analysis?

@ruben1dlg, I think TA Peter is referring to the EDA section in the final report. Would you see if there is anything to cut from the final report?

[stevenleung2018]

a single number doesn't make a table

@ming0701 @ruben1dlg I think he is referring to the p-value in results/04_htest.html and doc/05_final_report.html. Please think about changing it.

[stevenleung2018]

@pgysbers We appreciate your feedback. We might not have enough time to respond to all issues but we have done for some of them (for Milestones 1 and 2). You can refer to the comment here for the list of our responses.