Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Review Model and Django Admin Review filter #99

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Feature: Review Model and Django Admin Review filter #99

merged 1 commit into from
Dec 3, 2021

Conversation

daload
Copy link
Contributor

@daload daload commented Dec 1, 2021

  • Reviews Model Created
  • Django Admin Review filter created
  • Added Reviews app to settings.py

@daload
- Reviews Model Created
18cc0df 
- Django Admin Review filter created
- Added Reviews app to settings.py
@daload daload self-assigned this Dec 1, 2021
This was linked to issues Dec 1, 2021
[US4 - T1] Create Reviews Model #96
Open
[US33 - T1] Create Filter for reviews #98
Open
@daload daload requested a review from eduvives December 1, 2021 17:09
@codecov
Copy link

codecov bot commented Dec 1, 2021 •
edited
Loading

Codecov Report

Merging #99 (18cc0df) into development (dd2decc) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #99      +/-   ##
===============================================
+ Coverage        95.16%   95.31%   +0.14%     
===============================================
  Files               44       49       +5     
  Lines              973     1004      +31     
===============================================
+ Hits               926      957      +31     
  Misses              47       47
Impacted Files Coverage Δ
wannasellbackend/settings.py 95.23% <ø> (ø)
reviews/admin.py 100.00% <100.00%> (ø)
reviews/apps.py 100.00% <100.00%> (ø)
reviews/migrations/0001_initial.py 100.00% <100.00%> (ø)
reviews/migrations/0002_review_check.py 100.00% <100.00%> (ø)
reviews/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2decc...18cc0df. Read the comment docs.

@daload
Copy link
Contributor Author

daload commented Dec 1, 2021

@eduvives mirat el model i diga'm si necessites alguna cosa mes

@daload daload removed the request for review from eduvives December 1, 2021 20:43
werogg
werogg approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@werogg werogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@werogg werogg merged commit 83a0be5 into development Dec 3, 2021
@eduvives
Copy link

eduvives commented Dec 3, 2021 •
edited
Loading

@daload El modelo de la review está perfecto. Para la siguiente PR porfavor añade también la fecha en la que se ha realizado la review. Así podemos mostrarla en el frontend junto al reviewer, message...

@carlaMorral carlaMorral deleted the feat/reviews branch December 3, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werogg werogg werogg approved these changes

Assignees

@daload daload

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[US33 - T1] Create Filter for reviews [US4 - T1] Create Reviews Model
3 participants
@daload @eduvives @werogg