Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Reviews View #109

Merged
merged 2 commits into from
Dec 5, 2021
Merged

FEAT: Reviews View #109

merged 2 commits into from
Dec 5, 2021

Conversation

daload
Copy link
Contributor

@daload daload commented Dec 3, 2021

  • Added Reviews endpoint (GET, POST and PATCH)

@daload daload self-assigned this Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021 •
edited
Loading

Codecov Report

Merging #109 (0a65900) into development (2f7691c) will increase coverage by 0.37%.
The diff coverage is 97.67%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #109      +/-   ##
===============================================
+ Coverage        95.79%   96.16%   +0.37%     
===============================================
  Files               58       62       +4     
  Lines             1260     1486     +226     
===============================================
+ Hits              1207     1429     +222     
- Misses              53       57       +4
Impacted Files Coverage Δ
wannasellbackend/urls.py 100.00% <ø> (ø)
reviews/views.py 93.75% <93.75%> (ø)
reviews/serializers.py 100.00% <100.00%> (ø)
reviews/tests.py 100.00% <100.00%> (ø)
reviews/urls.py 100.00% <100.00%> (ø)
products/serializers.py 98.48% <0.00%> (+0.04%) ⬆️
products/tests.py 98.89% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7691c...0a65900. Read the comment docs.

@daload daload linked an issue Dec 3, 2021 that may be closed by this pull request
[US27 - T1] Create Review API #97
Open
carlaMorral
carlaMorral approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@carlaMorral carlaMorral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to add everything on the docs :)

carlaMorral
carlaMorral approved these changes Dec 4, 2021
View reviewed changes
Copy link
Collaborator

@carlaMorral carlaMorral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daload daload merged commit 8e2215c into development Dec 5, 2021
@carlaMorral carlaMorral deleted the feat/reviews-view branch December 17, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlaMorral carlaMorral carlaMorral approved these changes

Assignees

@daload daload

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[US27 - T1] Create Review API
2 participants
@daload @carlaMorral