Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/field prod sold #94

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Feat/field prod sold #94

merged 2 commits into from
Nov 30, 2021

Conversation

carlaMorral
Copy link
Collaborator

Add the 'sold' field to the Product model

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #94 (a1c9eb0) into development (510fcc3) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #94      +/-   ##
===============================================
+ Coverage        95.01%   95.16%   +0.15%     
===============================================
  Files               43       44       +1     
  Lines              963      973      +10     
===============================================
+ Hits               915      926      +11     
+ Misses              48       47       -1     
Impacted Files Coverage Δ
products/migrations/0012_product_sold.py 100.00% <100.00%> (ø)
products/models.py 92.30% <100.00%> (+0.15%) ⬆️
products/serializers.py 98.24% <100.00%> (+0.03%) ⬆️
products/tests.py 97.87% <100.00%> (+0.06%) ⬆️
products/views.py 85.29% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510fcc3...a1c9eb0. Read the comment docs.

@carlaMorral carlaMorral changed the base branch from production to development November 30, 2021 23:16
Copy link
Collaborator

@werogg werogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@werogg werogg merged commit dd2decc into development Nov 30, 2021
@carlaMorral carlaMorral linked an issue Dec 3, 2021 that may be closed by this pull request
@carlaMorral carlaMorral deleted the feat/field-prod-sold branch December 3, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US21 - T3] Add 'sold' column to Product model
2 participants