fix(sdk): resolve unused variable warnings in generated contract files

Improve TypeScript and ESLint configuration to properly handle unused variables:
- Set `noUnusedLocals` and `noUnusedParameters` to false in tsconfig.json
- Add explicit `exclude` for contract client files in tsconfig.json
- Upgrade unused variables ESLint rule from warning to error
- Add `coverage` directory to ESLint ignores
- Add `typecheck` script to package.json
- Add Type Check step to CI workflow

This approach maintains strict code quality checks while preventing false
positives from generated files.

Author: drichar

.github/workflows/ci.yml

@@ -46,6 +46,9 @@ jobs:
       - name: Lint
         run: pnpm -F @txnlab/nfd-sdk lint
 
+      - name: Type Check
+        run: pnpm -F @txnlab/nfd-sdk typecheck
+
       - name: Test
         run: pnpm -F @txnlab/nfd-sdk test
 

eslint.config.js

@@ -43,12 +43,12 @@ export default tseslint.config(
       '@typescript-eslint/no-explicit-any': 'warn',
       '@typescript-eslint/explicit-function-return-type': 'off',
       '@typescript-eslint/no-unused-vars': [
-        'warn',
+        'error',
         { argsIgnorePattern: '^_' },
       ],
     },
   },
   {
-    ignores: ['**/node_modules/*', '**/dist/*'],
+    ignores: ['**/node_modules/*', '**/dist/*', '**/coverage/*'],
   },
 )

packages/sdk/package.json

@@ -18,6 +18,7 @@
     "test:coverage": "vitest run --coverage",
     "lint": "eslint \"**/*.{js,jsx,ts,tsx}\"",
     "format": "prettier --write .",
+    "typecheck": "tsc --noEmit",
     "publish:package": "node scripts/publish.js",
     "fetch:openapi": "tsx scripts/fetch-openapi.ts",
     "fetch:arc56": "tsx scripts/fetch-arc56.ts",

packages/sdk/tsconfig.json

@@ -11,12 +11,16 @@
     "isolatedModules": true,
     "noEmit": true,
     "strict": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
     "noFallthroughCasesInSwitch": true,
     "paths": {
       "@/*": ["./src/*"]
     }
   },
-  "include": ["src", "tests"]
+  "include": ["src", "tests"],
+  "exclude": [
+    "src/contracts/NFDInstanceClient.ts",
+    "src/contracts/NFDRegistryClient.ts"
+  ]
 }