Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase multiplayer lib on another fork (like swift's) #81

Closed
TwinFan opened this issue Jan 26, 2019 · 4 comments
Closed

Rebase multiplayer lib on another fork (like swift's) #81

TwinFan opened this issue Jan 26, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request XPMP2 Affects XPMP2 lib

Comments

@TwinFan
Copy link
Owner

TwinFan commented Jan 26, 2019

Current Situation / Problem
My multiplayer fork is based on kuroneko's, which might be fairly original, but also unchanged for 2y now.

Suggested Solution
Rebase on another fork: swift or xfs.

On first compare xfs seems to be a bit ahead at the moment, has e.g. the clamp logic and the taxi light thingy.

Benefits
Benefit from all enhancements and fixes already in the newer versions (which still are unchange since Feb 2018), especially

  • OBJ8 format allowing for multi-liveries
  • clamping, which seems to a way of deriving the lowest point in a model to make it roll on wheels without the need for VERT_OFFSET
  • taxi lights (to replace current logic to optionally keep landing lights on during taxi Optional Landing Lights during taxi #76)

Additional context
Still need to recreate some stuff:

@TwinFan TwinFan self-assigned this Jan 26, 2019
@TwinFan TwinFan added the enhancement New feature or request label Jan 26, 2019
@TwinFan TwinFan added this to the v1.0 milestone Jan 26, 2019
@kuroneko
Copy link

You could just talk to me.

@TwinFan
Copy link
Owner Author

TwinFan commented Feb 2, 2019

Merged current kuroneko/master, which

Had to merge some of my changes in, though:

@TwinFan
Copy link
Owner Author

TwinFan commented Feb 2, 2019

With this change further decisions moved out to after v1.0

@TwinFan TwinFan modified the milestones: v1.0, After 1.0 Feb 2, 2019
@TwinFan TwinFan added the XPMP2 Affects XPMP2 lib label Mar 4, 2019
@TwinFan
Copy link
Owner Author

TwinFan commented Jun 24, 2019

All benefits are available by now without basing on another fork. Closed.

@TwinFan TwinFan closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request XPMP2 Affects XPMP2 lib
Projects
None yet
Development

No branches or pull requests

2 participants