Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssh): Support authless connection #723

Open
jinnatar opened this issue Apr 6, 2024 · 0 comments
Open

fix(ssh): Support authless connection #723

jinnatar opened this issue Apr 6, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jinnatar
Copy link

jinnatar commented Apr 6, 2024

Describe the feature request

A mode of the SSH check that would only check for a valid SSH connection banner. It's an upgrade from a plain TCP check but lighter weight than a full SSH check as done today.

An example of a borked OpenSSH server that passes a TCP check:

❯ nc borked.example.com 22
EHLO

... After which the connection terminates.

An example of a functioning OpenSSH server:

❯ nc fine.example.com 22
SSH-2.0-OpenSSH_9.2p1 Debian-2+deb12u2
EHLO
Invalid SSH identification string.

... After which the connection terminates.

Why do you personally want this feature to be implemented?

While the current SSH check does allow checking an SSH endpoint it has limitations that I'd love to overcome:

  • It can only validate with authentication -> Requires exposing credentials to monitoring, even if it can be done via env variables.
  • It requires password auth -> No support for pubkey auth, requires keeping password auth enabled in sshd which is against security best practices.

How long have you been using this project?

1y

Additional information

The banner check is just the first idea I was able to confirm in a real scenario. If someone knows a bit more of the protocol then perhaps there's more quick wins a bit deeper. But, then again a quick "does the server send any banner after TCP open would already be a big improvement.

@TwiN TwiN changed the title FR: authless basic SSH checking fix(ssh): Support authless connection Apr 9, 2024
@TwiN TwiN added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants