Fix tests

Author: penelopeysm

ext/SliceSamplingTuringExt.jl

@@ -22,24 +22,17 @@ Turing.Inference.isgibbscomponent(::SliceSampling.Slice) = true
 Turing.Inference.isgibbscomponent(::SliceSampling.SliceSteppingOut) = true
 Turing.Inference.isgibbscomponent(::SliceSampling.SliceDoublingOut) = true
 
-function Turing.Inference.getparams(
-    ::Turing.DynamicPPL.Model, sample::SliceSampling.UnivariateSliceState
-)
+const SliceSamplingStates = Union{
+    SliceSampling.UnivariateSliceState,
+    SliceSampling.GibbsState,
+    SliceSampling.HitAndRunState,
+    SliceSampling.LatentSliceState,
+    SliceSampling.GibbsPolarSliceState,
+}
+function Turing.Inference.getparams(::Turing.DynamicPPL.Model, sample::SliceSamplingStates)
     return sample.transition.params
 end
 
-function Turing.Inference.getparams(
-    ::Turing.DynamicPPL.Model, state::SliceSampling.GibbsState
-)
-    return state.transition.params
-end
-
-function Turing.Inference.getparams(
-    ::Turing.DynamicPPL.Model, state::SliceSampling.HitAndRunState
-)
-    return state.transition.params
-end
-
 function Turing.Inference.getlogp_external(
     ::Turing.DynamicPPL.Model, t::SliceSampling.Transition, state
 )

test/turing.jl

@@ -8,7 +8,10 @@
         return nothing
     end
 
-    @model logp_check() = x ~ Normal()
+    @model function logp_check()
+        a ~ Normal()
+        return b ~ Normal()
+    end
 
     n_samples = 1000
     model = demo()
@@ -36,7 +39,11 @@
         chain_logp_check = sample(
             logp_check(), externalsampler(sampler), 100; progress=false
         )
-        @test isapprox(logpdf.(Normal(), chain_logp_check[:x]), chain_logp_check[:logp])
+        @test isapprox(
+            logpdf.(Normal(), chain_logp_check[:a]) .+
+            logpdf.(Normal(), chain_logp_check[:b]),
+            chain_logp_check[:lp],
+        )
     end
 
     @testset "gibbs($sampler)" for sampler in [
@@ -55,8 +62,15 @@
         )
 
         chain_logp_check = sample(
-            logp_check(), Turing.Gibbs(:x => externalsampler(sampler)), 100; progress=false
+            logp_check(),
+            Turing.Gibbs(:a => externalsampler(sampler), :b => externalsampler(sampler)),
+            100;
+            progress=false,
+        )
+        @test isapprox(
+            logpdf.(Normal(), chain_logp_check[:a]) .+
+            logpdf.(Normal(), chain_logp_check[:b]),
+            chain_logp_check[:lp],
         )
-        @test isapprox(logpdf.(Normal(), chain_logp_check[:x]), chain_logp_check[:logp])
     end
 end