Skip to content

Looks+: Recoloring a costume resets its rotation center #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmberEP opened this issue Feb 24, 2025 · 7 comments · May be fixed by #1517
Open

Looks+: Recoloring a costume resets its rotation center #1963

AmberEP opened this issue Feb 24, 2025 · 7 comments · May be fixed by #1517

Comments

@AmberEP
Copy link

AmberEP commented Feb 24, 2025

When changing an svg color, it resets its x and y offset and changes its rotation point. I could manually fix the x and y offset but i can't solve the rotation point problem.

I need it because i suppose there is way to make a sprite change color AND brightness.
For my character, to make its skin customizable, i created (for each body segment) 1 layer for the outline (back layer) that is black, 1 for the skin (red by default then the color can change depending on the skin tone, and brightness effect can change) and 1 other for the skin brightness (black).

skin and its outline, with the 3 layers (1og and 2 clones. It may slow the game a lot when i'll add the 7 others athletes (21 sprites for each, and 42 clones (even more clones if not naked...)))
Image

for example, the arm new position when i use the extension to change its color is this :
Image

@SharkPool-SP
Copy link
Collaborator

SharkPool-SP commented Feb 24, 2025

for the record, this isnt exactly a issue with Looks+ its more of a issue with how rotation centers are applied with Scratch skins.
The way its coded, Looks+ and Skins causes Scratch Skins to default to a rotation center of 0,0. Its not easy to implement either because of certain things...

However, there is a PR in this repository and some others to work towards fixing it. In the mean time, you could add a invisible box to your costume to keep the rotation center, or alternatively, use other extensions to manually set the rotation center

@GarboMuffin
Copy link
Member

I believe this would be fixed by #1517

We can unblock it even though the centering for bitmaps isn't ready yet

@GarboMuffin GarboMuffin linked a pull request Feb 24, 2025 that will close this issue
@SharkPool-SP
Copy link
Collaborator

I believe this would be fixed by #1517

We can unblock it even though the centering for bitmaps isn't ready yet

dont you need to edit Looks+ and Skins too?

@AmberEP AmberEP closed this as completed Feb 24, 2025
@AmberEP
Copy link
Author

AmberEP commented Feb 24, 2025

I didn't even think of the invisible box.
Interesting. I'll first check how the extensions works then if it's too hard, I'll add the invisible box. Thanks !

@GarboMuffin
Copy link
Member

Leave it open, it's not fixed yet

dont you need to edit Looks+ and Skins too?

yes i forgot that pull request only touched Assets

@GarboMuffin GarboMuffin reopened this Feb 24, 2025
@AmberEP AmberEP closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2025
@AmberEP AmberEP reopened this Feb 24, 2025
@AmberEP
Copy link
Author

AmberEP commented Feb 24, 2025

oh sorry i don't really know how it works there.

@SharkPool-SP
Copy link
Collaborator

I didn't even think of the invisible box. Interesting. I'll first check how the extensions works then if it's too hard, I'll add the invisible box. Thanks !

yeah just so you know, no extensions on the Turbowarp gallery has a manual set rotation center block.
Mainly external extensions like Renderer Control and Turbo Skins (in my gallery)

@DNin01 DNin01 changed the title LilyMakeThings • looks+ Extension Looks+: Recoloring a costume resets its rotation center Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants