Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Election endpoint and update spec #22

Open
2 tasks
alanyst opened this issue Mar 15, 2023 · 3 comments
Open
2 tasks

Implement Election endpoint and update spec #22

alanyst opened this issue Mar 15, 2023 · 3 comments
Assignees

Comments

@alanyst
Copy link
Collaborator

alanyst commented Mar 15, 2023

  • GET /reporting-units/{reportingUnitId}/elections
  • Add DELETE endpoint to spec (allowed only in certain cases)
@alanyst alanyst self-assigned this Mar 15, 2023
@stratofax
Copy link
Collaborator

A comment for this and your other two, related API endpoint issues:

I took a quick look at your code and it looks like you're using pydantic for your API endpoint modules. This is an excellent choice, but I wanted to mention that @ion-oset and I have done quite a bit of work with FastAPI. This is in fact based on Pydantic as well. Have you taken a look at FastAPI? It's an excellent enhancement to pydantic. See the FastAPI site for details, if you haven't already

@alanyst
Copy link
Collaborator Author

alanyst commented Mar 15, 2023

@stratofax The API endpoints are implemented using FastAPI (the app/routers files). The data classes (such as Candidate) are implemented using Pydantic, and are found in models/nist/classes.

@stratofax
Copy link
Collaborator

stratofax commented Mar 15, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants