Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CLI options for logging destination, level #69

Open
stratofax opened this issue Aug 16, 2022 · 0 comments
Open

Implement CLI options for logging destination, level #69

stratofax opened this issue Aug 16, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@stratofax
Copy link
Collaborator

Currently, logging is set in this app's entry point (cli.py) as follows:

logging.basicConfig(stream=sys.stdout, level=logging.DEBUG)

This is useful for debugging, but not appropriate for production code. These default values should be re-evaluated when it's time to ship -- most likely, something like this:

stream=sys.stderr, level=logging.ERROR

In addition, the CLI (and settings file, when it exists) should allow end users to set:

  • the logging level they'd like to use
  • the output destination (stdout or a specific log file, for example)

Since these options control how "verbose" the output is, we either:

  • don't need a "verbose" option
  • could use "verbose" as a logging preset -- for example, set logging level to INFO and all notifications to stdout
@stratofax stratofax self-assigned this Aug 16, 2022
@stratofax stratofax added the enhancement New feature or request label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant