Update Serialization.kt with auto functionality #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 3e4a42d)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
============================================
+ Coverage 58.62% 58.73% +0.10%
Complexity 702 702
============================================
Files 107 107
Lines 4553 4553
Branches 632 632
============================================
+ Hits 2669 2674 +5
+ Misses 1552 1549 -3
+ Partials 332 330 -2 ☔ View full report in Codecov by Sentry. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87
Closes #86
(cherry picked from commit 3e4a42d)
This pull requests fixes the two mentioned issues or design flaws related to Int and UShort transit.
If permitted, I would just change the signature of the original UShort functions and all the usages in the code to explicitly cast the data before sending to (de)serializer.
This also includes functions to automatically select the proper (de)serializer based on the underlying, allowing for more clean code in simple cases.
I was not able to automatically perform deserialization due to issues with typing of static classes and usage of Companion, as such it has been left out for now.