-
-
Notifications
You must be signed in to change notification settings - Fork 183
useSurfaceSampler is not a composable #1132
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingcientosIssues related to @tresjs/cientosIssues related to @tresjs/cientosdxp4-important-bugViolate documented behavior or significantly improve performance (priority)Violate documented behavior or significantly improve performance (priority)
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcientosIssues related to @tresjs/cientosIssues related to @tresjs/cientosdxp4-important-bugViolate documented behavior or significantly improve performance (priority)Violate documented behavior or significantly improve performance (priority)
Type
Projects
Status
Done
Describe the bug
While adding
on-demandinvalidation on theuseSurfaceSamplerandSampleron Tresjs/cientos#436 I noticed thatuseSurfaceSampleris not a vue composable per definition (it doesn't deal with any type of reactivity or state), is just a function. See why here https://vuejs.org/guide/reusability/composables#what-is-a-composableSince we are providing to our users as it was a composable, I would expect that the options are reactive.
https://github.com/Tresjs/cientos/blob/9e17559fc98066db79b02b7ea0c98ae3037ac906/src/core/abstractions/useSurfaceSampler/index.ts#L81-L143
Reproduction
Local playground, run useSurfaceSampler
Steps to reproduce
No response
System Info
System: OS: macOS 14.5 CPU: (8) arm64 Apple M1 Pro Memory: 89.09 MB / 16.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 20.12.2 - ~/.nvm/versions/node/v20.12.2/bin/node Yarn: 1.22.19 - /usr/local/bin/yarn npm: 10.5.0 - ~/.nvm/versions/node/v20.12.2/bin/npm pnpm: 8.15.4 - ~/Library/pnpm/pnpm bun: 1.0.2 - ~/.bun/bin/bun Browsers: Brave Browser: 120.1.61.116 Chrome: 125.0.6422.142 Safari: 17.5 npmPackages: @tresjs/core: 4.0.2 => 4.0.2 @tresjs/leches: ^0.14.0 => 0.14.0Used Package Manager
pnpm
Code of Conduct