Skip to content

Commit 9b69b17

Browse files
Merge pull request #18 from Trendyol/feature/improve-put-in-the-field
feature: Improve `putInTheField` methods
2 parents 6a3c919 + 4ddb4d6 commit 9b69b17

File tree

7 files changed

+21
-14
lines changed

7 files changed

+21
-14
lines changed

es/aggregations.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,9 +180,10 @@ func AggCustom(agg Object) aggsType {
180180
}
181181

182182
func (agg aggsType) putInTheField(key string, value any) aggsType {
183-
for field := range agg {
184-
if fieldObject, ok := agg[field].(Object); ok {
183+
for _, fieldObj := range agg {
184+
if fieldObject, ok := fieldObj.(Object); ok {
185185
fieldObject[key] = value
186+
break
186187
}
187188
}
188189
return agg

es/base_query.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,9 +224,10 @@ func Sort(field string) sortType {
224224
}
225225

226226
func (s sortType) putInTheField(key string, value any) sortType {
227-
for field := range s {
228-
if fieldObject, ok := s[field].(Object); ok {
227+
for _, fieldObj := range s {
228+
if fieldObject, ok := fieldObj.(Object); ok {
229229
fieldObject[key] = value
230+
break
230231
}
231232
}
232233
return s

es/match_none_query.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ func MatchNone[T any](key string, query T) matchNoneType {
3434

3535
func (m matchNoneType) putInTheField(key string, value any) matchNoneType {
3636
if matchNone, ok := m["match_none"].(Object); ok {
37-
for field := range matchNone {
38-
if fieldObject, foOk := matchNone[field].(Object); foOk {
37+
for _, fieldObj := range matchNone {
38+
if fieldObject, foOk := fieldObj.(Object); foOk {
3939
fieldObject[key] = value
40+
break
4041
}
4142
}
4243
}

es/match_query.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ func Match[T any](key string, query T) matchType {
3434

3535
func (m matchType) putInTheField(key string, value any) matchType {
3636
if match, ok := m["match"].(Object); ok {
37-
for field := range match {
38-
if fieldObject, foOk := match[field].(Object); foOk {
37+
for _, fieldObj := range match {
38+
if fieldObject, foOk := fieldObj.(Object); foOk {
3939
fieldObject[key] = value
40+
break
4041
}
4142
}
4243
}

es/query_string.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -557,9 +557,10 @@ func (q queryStringType) TimeZone(value string) queryStringType {
557557
}
558558

559559
func (q queryStringType) putInTheField(key string, value any) queryStringType {
560-
for field := range q {
561-
if fieldObject, ok := q[field].(Object); ok {
560+
for _, fieldObj := range q {
561+
if fieldObject, ok := fieldObj.(Object); ok {
562562
fieldObject[key] = value
563+
break
563564
}
564565
}
565566
return q

es/regexp_query.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@ func Regexp(key string, value string) regexpType {
3232

3333
func (r regexpType) putInTheField(key string, value any) regexpType {
3434
if regexp, ok := r["regexp"].(Object); ok {
35-
for field := range regexp {
36-
if fieldObject, foOk := regexp[field].(Object); foOk {
35+
for _, fieldObj := range regexp {
36+
if fieldObject, foOk := fieldObj.(Object); foOk {
3737
fieldObject[key] = value
38+
break
3839
}
3940
}
4041
}

es/simple_query_string.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,9 +298,10 @@ func (q simpleQueryStringType) QuoteFieldSuffix(value string) simpleQueryStringT
298298
}
299299

300300
func (q simpleQueryStringType) putInTheField(key string, value any) simpleQueryStringType {
301-
for field := range q {
302-
if fieldObject, ok := q[field].(Object); ok {
301+
for _, fieldObj := range q {
302+
if fieldObject, ok := fieldObj.(Object); ok {
303303
fieldObject[key] = value
304+
break
304305
}
305306
}
306307
return q

0 commit comments

Comments
 (0)