Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged profiles do not inherit properties and PII #892

Open
pedroarinto opened this issue Dec 19, 2024 · 2 comments
Open

Merged profiles do not inherit properties and PII #892

pedroarinto opened this issue Dec 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@pedroarinto
Copy link

Describe the bug

When profiles are merged by the APM worker, all profile properties are lost, as well as PII information. Profile traits and Segments are merged.

To Reproduce

Tested on v 1.1.1

  1. On a device send a Sign-up event with email.main, firstname and lastname. The profile is correctly created with The email.main property and PII.firstname and PII.lastname are set.
  2. On another device, send a pageview event first. An anonymous profile is created.
  3. On this second device, send a sign-in event with the same email as the first device
  4. The profiles are merged, but all properties and PII are lost. The profile is set as anonymous.

Expected behavior

The profiles should be merged, and they should inherit the set properties and PII from the first profile.
Instead, the profiles are correctly merged but they are set as Anonymous without properties or PII.

@pedroarinto pedroarinto added the bug Something isn't working label Dec 19, 2024
@pedroarinto
Copy link
Author

To clarify, this is using the open-source version of Tracardi, with a docker instalation (tracardi/apm:1.1.1). tracardi-gui and tracardi-api is also running 1.1.1.

@pedroarinto
Copy link
Author

Hi,

I've found the problem. In tracardi/service/profile_merger.py, line 161, the ProfileData object creation is wrong. It should be:

data = ProfileData(**new_value['data']['data'])

and not

data = ProfileData(**new_value['data'])

With this change profiles are merged correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant