[NU-2109] Remove unknown scenario property validation (#7757)

Author: lukasz-bigorajski

designer/server/src/main/scala/pl/touk/nussknacker/ui/validation/ScenarioPropertiesValidator.scala

@@ -5,7 +5,7 @@ import cats.data.Validated.{invalid, valid, Invalid, Valid}
 import pl.touk.nussknacker.engine.api.NodeId
 import pl.touk.nussknacker.engine.api.component.ScenarioPropertyConfig
 import pl.touk.nussknacker.engine.api.context.PartSubGraphCompilationError
-import pl.touk.nussknacker.engine.api.context.ProcessCompilationError.{MissingRequiredProperty, UnknownProperty}
+import pl.touk.nussknacker.engine.api.context.ProcessCompilationError.MissingRequiredProperty
 import pl.touk.nussknacker.engine.api.definition.{MandatoryParameterValidator, ParameterValidator}
 import pl.touk.nussknacker.engine.api.parameter.ParameterName
 import pl.touk.nussknacker.engine.graph.expression.Expression
@@ -34,9 +34,8 @@ class ScenarioPropertiesValidator(
     val validated = (
       getConfiguredValidationsResults(finalizedScenarioPropertiesConfig, scenarioProperties),
       getMissingRequiredPropertyValidationResults(finalizedScenarioPropertiesConfig, scenarioProperties),
-      getUnknownPropertyValidationResults(finalizedScenarioPropertiesConfig, scenarioProperties)
     )
-      .mapN { (_, _, _) => () }
+      .mapN { (_, _) => () }
 
     val processPropertiesErrors = validated match {
       case Invalid(e) => e.map(error => PrettyValidationErrors.formatErrorMessage(error)).toList
@@ -96,19 +95,6 @@ class ScenarioPropertiesValidator(
       .map(_ => ())
   }
 
-  private def getUnknownPropertyValidationResults(
-      config: PropertyConfig,
-      scenarioProperties: List[(String, String)]
-  ) = {
-    scenarioProperties
-      .map(property => (property._1, UnknownPropertyValidator(config)))
-      .map { case (propertyName, validator) =>
-        validator.isValid(propertyName).toValidatedNel
-      }
-      .sequence
-      .map(_ => ())
-  }
-
 }
 
 private final case class MissingRequiredPropertyValidator(actualPropertyNames: List[String]) {
@@ -124,15 +110,3 @@ private final case class MissingRequiredPropertyValidator(actualPropertyNames: L
   }
 
 }
-
-private final case class UnknownPropertyValidator(config: Map[String, ScenarioPropertyConfig]) {
-
-  def isValid(propertyName: String)(implicit nodeId: NodeId): Validated[PartSubGraphCompilationError, Unit] = {
-    if (config.contains(propertyName)) {
-      valid(())
-    } else {
-      invalid(UnknownProperty(ParameterName(propertyName)))
-    }
-  }
-
-}

designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ValidationResourcesSpec.scala

@@ -117,7 +117,6 @@ class ValidationResourcesSpec
       val entity = entityAs[String]
       entity should include("Configured property requiredStringProperty (label) is missing")
       entity should include("Property numberOfThreads has invalid value")
-      entity should include("Unknown property unknown")
       entity should include("This field value has to be an integer number")
     }
   }

designer/server/src/test/scala/pl/touk/nussknacker/ui/integration/BaseFlowTest.scala

@@ -345,7 +345,6 @@ class BaseFlowTest
     validationResponse.code shouldEqual StatusCode.Ok
     validationResponse.body should include("Configured property environment (Environment) is missing")
     validationResponse.body should include("This field value has to be an integer number")
-    validationResponse.body should include("Unknown property unknown")
     validationResponse.body should include("Property numberOfThreads (Number of threads) has invalid value") //
   }
 

designer/server/src/test/scala/pl/touk/nussknacker/ui/validation/ScenarioPropertiesValidatorTest.scala

@@ -246,27 +246,4 @@ class ScenarioPropertiesValidatorTest extends AnyFunSuite with Matchers {
     }
   }
 
-  test("validate non empty config with unknown property") {
-    val unknownProperty = "unknown"
-    val result = validator.validate(
-      Map(
-        "propReq"       -> "5",
-        unknownProperty -> "some text"
-      ).toList
-    )
-
-    result.errors.processPropertiesErrors should matchPattern {
-      case List(
-            NodeValidationError(
-              "UnknownProperty",
-              _,
-              _,
-              Some(`unknownProperty`),
-              NodeValidationErrorType.SaveAllowed,
-              None
-            )
-          ) =>
-    }
-  }
-
 }

designer/server/src/test/scala/pl/touk/nussknacker/ui/validation/UIProcessValidatorSpec.scala

@@ -624,34 +624,6 @@ class UIProcessValidatorSpec extends AnyFunSuite with Matchers with TableDrivenP
     validate(validScenarioGraphWithFields(Map("field2" -> "true"))) should not be withoutErrorsAndWarnings
   }
 
-  test("handle unknown properties validation") {
-    val processValidator = ProcessTestData.testProcessValidator(
-      scenarioProperties = Map(
-        "field2" -> ScenarioPropertyConfig(
-          defaultValue = None,
-          editor = None,
-          validators = Some(List(CompileTimeEvaluableValueValidator)),
-          label = Some("label"),
-          hintText = None
-        )
-      ) ++ FlinkStreamingPropertiesConfig.properties
-    )
-
-    val result =
-      processValidator.validate(
-        validScenarioGraphWithFields(Map("field1" -> "true")),
-        ProcessTestData.sampleProcessName,
-        isFragment = false,
-        labels = List.empty,
-      )
-
-    result.errors.processPropertiesErrors should matchPattern {
-      case List(
-            NodeValidationError("UnknownProperty", _, _, Some("field1"), NodeValidationErrorType.SaveAllowed, None)
-          ) =>
-    }
-  }
-
   test("not allows save with incorrect characters in ids") {
     def process(nodeId: String) = createGraph(
       List(Source(nodeId, SourceRef(ProcessTestData.existingSourceFactory, List()))),