Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libjpeg sources from repo and use turbojpeg instead #319

Open
6 of 12 tasks
flsobral opened this issue Mar 19, 2021 · 1 comment · May be fixed by #316
Open
6 of 12 tasks

Remove libjpeg sources from repo and use turbojpeg instead #319

flsobral opened this issue Mar 19, 2021 · 1 comment · May be fixed by #316
Assignees
@flsobral
Labels
All platforms Issue related to the all platforms build Performance

Comments

@flsobral
Copy link
Member

flsobral commented Mar 19, 2021 •
edited
Loading

  • Convert totalcross custom code injected inside the jpeg sources in proper bindings for streams
  • Build jpegturbo automatically as a static library using CMake with SIMD enabled
  • Remove libjpeg sources from repo
  • Test new build on every target
    • Linux x64
    • Linux arm32v7
    • Linux arm64
    • Android
    • iOS
    • Win32
    • WinCE
    • MacOS (only used for debugging, but that's important for development)
  • Test performance on iMX6ULL
@flsobral flsobral added build All platforms Issue related to the all platforms Performance labels Mar 19, 2021
@flsobral flsobral self-assigned this Mar 19, 2021
@flsobral flsobral linked a pull request Mar 19, 2021 that will close this issue
cmake: remove jpeg sources from our repo and use turbojpeg instead #316
Draft
@flsobral
Copy link
Member Author

Results observed using a 2500x1095 image on a iMX6ULL:

loading the image at full size: 50% faster
using Image.getJpegBestFit to load the image at 1250x548: 20% faster

🚀 🚀 🚀

@flsobral flsobral pinned this issue Mar 19, 2021
@flsobral flsobral unpinned this issue Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flsobral flsobral

Labels
All platforms Issue related to the all platforms build Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: remove jpeg sources from our repo and use turbojpeg instead TotalCross/totalcross
1 participant
@flsobral