Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm module overloads flow identifier and probe identifier #17

Open
cunha opened this issue Feb 7, 2017 · 3 comments
Open

confirm module overloads flow identifier and probe identifier #17

cunha opened this issue Feb 7, 2017 · 3 comments

Comments

@cunha
Copy link
Member

cunha commented Feb 7, 2017

See the discussion here: #15 (comment)

@cunha
Copy link
Member Author

cunha commented Feb 7, 2017

Understood. I think the current interface is to blame (my fault).
The interface takes care of setting the fields to store the flow
identifier and the probe identifier.

I am not sure what the best approach is. Do you have ideas?

One approach is to keep these in an outer module. For example, if
I want to send 1024 probes at the same time, there is no way to
choose header field values to implement this (at least for ICMP).
We could let the library's user choose how it wants to store the
probe identifier, this way it would be natural to use the first bits
in the sequence number to store the probe identifier like you did.

The problem is that the library needs to match the response with the
probe. If the user can set the flow identifier in any way he wants,
can the library do the matching without the user having to pass
a function to extract the flow identifier?

@rlcalmeida
Copy link
Member

I can't think a good way without passing a function, maybe pass the position (and length) of the identifier in the packet?

@cunha
Copy link
Member Author

cunha commented Feb 8, 2017

I don't think position + length does it because the identifier might be spread across multiple fields.

Is there a way to brute force and check all fields in the response?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants