Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Decimal #51

Open
gaborbernat opened this issue Aug 19, 2020 · 3 comments
Open

Support for Decimal #51

gaborbernat opened this issue Aug 19, 2020 · 3 comments
Labels
blocked Blocked by external projects (toolchains, OS issues, etc) enhancement New feature or request upstream change required This issue requires changes in the simdjson library

Comments

@gaborbernat
Copy link

I've read in the documentation there's plan to support this. What status are these plans in? Thanks.
@TkTech
Copy link
Owner

TkTech commented Aug 19, 2020

Can you clarify what you're looking for? The library currently parses floats just fine.

@gaborbernat
Copy link
Author

Ability to parse floats as decimal and encode decimals within json objects.

@TkTech TkTech changed the title parse float support Support for Decimal Aug 20, 2020
@TkTech
Copy link
Owner

TkTech commented Aug 20, 2020

The usefulness of this feature is blocked by upstream issues, such as simdjson/simdjson#425 (comment). Without support for a new tape type to indicate, say, number-as-string, allowing decimals would cause silent overflows or precision truncating.

It will be supported, as soon as it can be.

@TkTech TkTech added enhancement New feature or request upstream change required This issue requires changes in the simdjson library labels Aug 20, 2020
@TkTech TkTech added the blocked Blocked by external projects (toolchains, OS issues, etc) label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked by external projects (toolchains, OS issues, etc) enhancement New feature or request upstream change required This issue requires changes in the simdjson library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TkTech @gaborbernat