Skip to content

Score Card Table #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhussajn opened this issue Feb 27, 2025 · 2 comments · Fixed by #187
Closed

Score Card Table #182

mhussajn opened this issue Feb 27, 2025 · 2 comments · Fixed by #187
Assignees
Labels

Comments

@mhussajn
Copy link
Collaborator

mhussajn commented Feb 27, 2025

https://www.figma.com/design/B8kHltTqt6HZ8jR98qcPAe/CPF-(Full-version)?node-id=487-117018&t=uGedskkCan3VclYb-4

The tooltip text: "Min. points needed to complete band"

@mhussajn mhussajn self-assigned this Feb 27, 2025
@mhussajn
Copy link
Collaborator Author

@skorekm what about seniority? it's not present in the db schema, or im just blind
Image

@skorekm
Copy link
Collaborator

skorekm commented Feb 27, 2025

Seniority is currently loosely tied with bands:
1-3 - Junior
4-6 - Mid
7+ - Senior

We can hardcode it for the time being

@mhussajn mhussajn linked a pull request Mar 10, 2025 that will close this issue
mhussajn added a commit that referenced this issue Apr 15, 2025
* feat: score card table UI

* feat: integrate ScoreCardTable and enhance MainLadder UI

* refactor: remove mapKeysToCamelCase utility and update related functions

* feat: add API route for fetching ladder data and update AddEmployeeForm to include buckets

* feat: add API route for fetching ladder data and update AddEmployeeForm to include buckets

* fix: set default border color to navy-200

* feat: add current band to people table

* feat: enhance MySpace and MainLadder components with improved user data handling and validation

* refactor: reorganize imports and enhance type definitions

* refactor: update Supabase client initialization and streamline sign-out logic

* refactor: employee addition logic and Supabase client usage

* refactor: update useGetPeopleList to include pagination parameters

* refactor: add 'use server' directive to handleSignOut function for server-side execution

* refactor: improve key generation for table rows in PeopleTable component

* feat: implement score card API route and add ScorCard to MySpace tab

* refactor: update Topbar component to use UserProfile type and enhance user data fetching

* feat: create PersonDetailsPage page and component

* feat: enhance seeding

* refactor: simplify query parameter handling in MySpace and LadderTab components

* refactor: add nosemgrep comment to random item selection in seedUsers function

* fix: personDetailsPage Params type

* refactor: change PersonDetailsPage to default export and remove TODO comment in LadderDetailed

* refactor: update GET handler params in ladder API

* refactor: update score card GET handler params type

* fix: optimize dependencies in People hooks to avoid rerender loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants