Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inconsistent whitespace in Page Toolbar's More actions #8921

Open
jn64 opened this issue Jan 30, 2025 · 1 comment · May be fixed by #8932
Open

[BUG] Inconsistent whitespace in Page Toolbar's More actions #8921

jn64 opened this issue Jan 30, 2025 · 1 comment · May be fixed by #8932

Comments

@jn64
Copy link

jn64 commented Jan 30, 2025

Describe the bug

In the Page Toolbar's More actions menu, some items have extra whitespace between the SVG icon and the text:

  • advanced search
  • tiddler manager
  • tag manager

Expected behavior

No response

To Reproduce

  1. Enable the More actions button in the Page Toolbar.

    E.g. go to https://tiddlywiki.com/#%24%3A%2FControlPanel → Appearance → Toolbars → Page Toolbar and check the box for more

  2. Click the More actions button in the sidebar.

Screenshots

Screenshot

TiddlyWiki Configuration

TiddlyWiki 5.3.6
Node.js 22.11.0

Additional context

No response

@ericshulman
Copy link
Member

ericshulman commented Feb 2, 2025

Curiously, when the $:/AdvancedSearch, $:/Manager, or $:/TagManager tiddlers is being viewed in the StoryRiver, the extra whitespace in the corresponding PageToolbar More menu item is gone.

Also, to fix the whitespace issue:

  • Edit $:/core/ui/Buttons/advanced-search, $:/core/ui/Buttons/manager, and $:/core/ui/Buttons/tag-manager
  • In each of these tiddlers, move the \whitespace trim pragma to immediately follow the \procedure ... pragma (i.e., so it occurs WITHIN the procedure definition)

@pmario pmario linked a pull request Feb 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants