Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great work #1

Open
ireneb612 opened this issue Jul 13, 2023 · 7 comments
Open

Great work #1

ireneb612 opened this issue Jul 13, 2023 · 7 comments

Comments

@ireneb612
Copy link

Hi this is a great work, but do you have a paper or something to read other than the documentation?
I would like to apply it to a policy on irregular migration

@ireneb612
Copy link
Author

Also I would like to add some controls! But it seems like you are just using the outcome and the treatment, How can I add other features?

@TianyiPeng
Copy link
Owner

Hi this is a great work, but do you have a paper or something to read other than the documentation? I would like to apply it to a policy on irregular migration

Thank you for expressing your interest! The estimators (along with their associated papers) that we have implemented can be found on the Readme page. As a starting point, I recommend considering the paper titled "Synthetic Difference-in-Differences," which has been gaining popularity in various empirical studies. You can access the paper by following this link: Synthetic Difference-in-Differences.

@TianyiPeng
Copy link
Owner

Also I would like to add some controls! But it seems like you are just using the outcome and the treatment, How can I add other features?

We are working on incorporating controls (other covariates and features) into the implementation. Can I ask you which method (or methods) you are considering using (this may help us prioritize the development)?

@ireneb612
Copy link
Author

Hi this is a great work, but do you have a paper or something to read other than the documentation? I would like to apply it to a policy on irregular migration

Thank you for expressing your interest! The estimators (along with their associated papers) that we have implemented can be found on the Readme page. As a starting point, I recommend considering the paper titled "Synthetic Difference-in-Differences," which has been gaining popularity in various empirical studies. You can access the paper by following this link: Synthetic Difference-in-Differences.

Thank you for the suggestions :)

@ireneb612
Copy link
Author

Also I would like to add some controls! But it seems like you are just using the outcome and the treatment, How can I add other features?

We are working on incorporating controls (other covariates and features) into the implementation. Can I ask you which method (or methods) you are considering using (this may help us prioritize the development)?

Actually I would like to use a simple diff in diff as based ground model and then try the synthetic diff and diff anche Matrix completion! Probably the MAtrix Completion would be the most urgent :) Thank you again

@ireneb612
Copy link
Author

@TianyiPeng any update? :)

@TianyiPeng
Copy link
Owner

@TianyiPeng any update? :)

Hi @ireneb612 , sorry for the delay! I just uploaded a new version for addressing covariates and missing data with the matrix completion method. The API usage can be found here. Let me know if you have any questions!

We did not implement the covariates for SDID since the paper did not explicitly describe a generic method (but let us know if there is a specific algorithm in your mind). For simple DID, we will clean up the API usage soon (although the code is actually already here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants