-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1658 Adds global header transforms #1659
base: release/24.0
Are you sure you want to change the base?
#1658 Adds global header transforms #1659
Conversation
@marklonquist Thanks Mark! Good job! Additionally I've added commits to make code quality better. |
Thanks for the PR! Can you update the docs so people know how to use it? |
@TomPallister Yes, we can! |
9a2c20c
to
a08f9f9
Compare
@marklonquist Hey Mark! |
According to the Tom's request we have to add documentation for this feature. |
very busy with work and familiy-life. I don't know exactly when I can have time to make docs for this. |
🆗 No worries! Take care about your family, and work & life balance! |
fixed |
f88bd51
to
108bede
Compare
I would appreciate it, if someone else can take over. I simply do not have the time to do any more work on this. |
@marklonquist I'm just curious: |
@raman-m yes! We use it on multiple BIG ecom sites, one of which is https://www.jackjones.com I actually just finished setting up kubernetes service discovery, but it doesn't work out of the box. Had to change the IKubeApiClient to be a singleton, because it doesn't work correctly when it is scoped it seems.
|
I believe it should be injected as singleton. As you may have noticed, most of Ocelot features are singleton services, historically by Tom's design. Please, keep us updated about your K8s environment with Ocelot behavior, how it is stable etc. |
I will provide you more detailed feedback on design of the interface on Monday... |
the kuberetes package adds it with ServiceCollectionServiceExtensions.AddScoped<KubeApiClient>(services, new Func<IServiceProvider, KubeApiClient>(ResolveWithPodServiceAccount));
ServiceCollectionServiceExtensions.AddScoped<IKubeApiClient>(services, new Func<IServiceProvider, IKubeApiClient>(ResolveWithPodServiceAccount)); anyway this is outside if this PRs scope. |
7c1b778
to
a18b0e7
Compare
a18b0e7
to
0e27766
Compare
The feature branch has been rebased onto release/24.0 with top commit 59b63ea ! @marklonquist Mark, |
Co-authored-by: Raman Maksimchuk <[email protected]>
… characters: should_*
0e27766
to
2b6ad65
Compare
TODOs
|
Closes #1658
Proposed Changes