Skip to content

Commit 5739ab8

Browse files
fix and update markdown
1 parent fc152a2 commit 5739ab8

File tree

5 files changed

+17
-10
lines changed

5 files changed

+17
-10
lines changed

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,12 @@ To get a local copy up and running follow these simple example steps.
143143

144144
<p align="right">(<a href="#readme-top">back to top</a>)</p>
145145

146+
### Known Issue
147+
* `'-r', '%.02f' % fps, must be real number, not NoneType` Not sure why it happen, can be fixed only by assign value for fps in `moviepy/video/io/ffmpeg_writer.py`, currently I assign the `30.0`
148+
* an temp audio file will be generate by will not be delete automatically
149+
* the avatar video in `webm` type have transparent background, it automatically become white, hid the image for news
150+
151+
On going fix for the issue: use FFMPEG instead of moviepy
146152

147153

148154
<!-- USAGE EXAMPLES -->

VideoGen/workers/information_collector.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def get_image_from_url(self, url:str, title: str = '') -> ImageInfo:
7272
image_info = ImageInfo(id=id, path=save_path, name=title, provider=InformationCollector.get_host(url))
7373
if self.config.use_ocr:
7474
image_info.ocr_result = " ".join(self.ocr_reader.readtext(image_info.path, detail = 0))
75-
self.storage.save_image_metadata(image_info, id)
75+
self.storage.save_image_metadata(image_info)
7676
return image_info
7777

7878
def get_webpage(self, url:str) -> WebpageInfo:

VideoGen/workers/table_visualizer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ def draw_table(self, table: TableInfo) -> ImageInfo:
3434
fig.write_image(image_data,scale=6)
3535
id, save_path = self.storage.save_image_content(image_data, 'png')
3636
image_info = ImageInfo(id=id, path=save_path, name=table.name)
37-
self.storage.save_image_metadata(image_info, id)
37+
self.storage.save_image_metadata(image_info)
3838

3939
return image_info

VideoGen/workers/video_director.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ def direct(self, raw_script:str, title: str):
152152
)
153153
if selected_image_index >= 0:
154154
image = images_to_be_selected.pop(selected_image_index)
155+
155156
illustration_channel.append(MovieImage(image.path, name=image_info.name, **image_param))
156157
lack_illustration_flag = False
157158
except Exception as e:

example_gen_video.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
from VideoGen.tool import ChinaCategory
88

99
load_dotenv()
10-
storage = LocalStorage(os.path.join("output", str(time.time_ns())))
11-
# storage = LocalStorage("output/1708786735037148000")
10+
# storage = LocalStorage(os.path.join("output", str(time.time_ns())))
11+
storage = LocalStorage("output/1711214304767606000")
1212

1313
config = ManagerConfig({
1414
"director_config": DirectorConfig({
@@ -35,10 +35,10 @@
3535
})
3636

3737
manager = Manager(storage, config)
38-
news = manager.search.news_category_trending(ChinaCategory.Auto.value)[0]
39-
webpage_info = manager.information_collector.get_webpage(news['url'])
40-
script = manager.video_director.webpage2script(webpage_info)
41-
draft_video = manager.video_director.direct(script, webpage_info.name)
42-
output_video_info = manager.video_director.export(draft_video)
43-
# output_video_info = manager.video_director.export()
38+
# news = manager.search.news_category_trending(ChinaCategory.Auto.value)[0]
39+
# webpage_info = manager.information_collector.get_webpage(news['url'])
40+
# script = manager.video_director.webpage2script(webpage_info)
41+
# draft_video = manager.video_director.direct(script, webpage_info.name)
42+
# output_video_info = manager.video_director.export(draft_video)
43+
output_video_info = manager.video_director.export()
4444

0 commit comments

Comments
 (0)