-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small tweaks allows running on ATMega2560 #403
Comments
I have tested this on our project that can be built for Mega2560 and ESP32 and the library works on both platforms with this tweak. I will open a PR for this shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The library does not compile out of the box for an Arduino ATMega2560 board (or any other 8-bit board)
To Reproduce
Steps to reproduce the behavior:
_frequency
overflowExpected behavior
Would be great to be able to use this library on a Arduino 8-bit board (almost there)
Versions (please complete the following information):
Additional context
If the type of the
_frequency
variable of theSSD1306Wire
class is changed fromint
tolong
, it will work.Also, using PlatformIO, I get compiler warnings about ctor parameters shadowing members. If you remove the leading underscores from the ctor parameters, it goes away.
The text was updated successfully, but these errors were encountered: