-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java Pages Sometimes missing words #11
Comments
I've tried inputting large amounts of text into the app with many different characters and from what I can gather it seems to work perfectly now. This could be because of a recent bug fix, but I'm not sure. Ideally #10 should be solved before any definite conclusions should be made, so 09cafdb will not be reversed yet. Additionally, #14 can be used as an alternative solution once solved, as users can choose if they want to "risk" word cutoff or not. For now tho, more manual testing may be the best bet. |
This is still (kinda) a problem, even with the new dataset from fdf3085. All words now exists, but will not fill the entire page. For example, inserting lorem ipsum I've found that it cuts off exactly one word too early, and inserts it at the start of the next page, but only in some cases.
|
I think I've figured some things out:
The first point explains why the space seems to be able to "not occupy space", it simply takes up less space, thus not causing a wrap.
The second point may explain why some words get cut off to early. Unless there is anything else I've been missing, these two issues should be the last part of the puzzle. |
After further testing it seems like the 122 width limit is incorrect. In fact, the wiki used to say 114 pixels, but was updated to 122 pixels in an edit: https://minecraft.wiki/w/Book_and_Quill?diff=prev&oldid=2488727. The author does not provide an explanation for this change, the entire edit message being: "Updated line width.". This can be proved with a simple test like this: The "a" has a width of 5 pixels, and the "." has a width of 1 pixels. The spacing between each character is 1 pixel. We can calculate the amount of pixels on the first row as such: |
The pixel width seems to be generally debated within the wiki. Here's a timeline:
There is no question however that the pixel width is 114, and as such the wiki is incorrect. |
Things seem to work now, as lorem ipsum is rendered correctly. I see no reason any other characters would be incorrectly handled either, as all character widths have been measured in the MGD project. We should resolve #10 before closing this issue however, just to be sure everything is fine. I'll continue working on some other issues in the meantime (which do not rely on this one). |
The program generates the commands correctly, however, java doesnt display some words at the end of pages sometimes, though the same words that arent showing on java show up on bedrock
also if you check my profile i have forked it for 50 page limit so it works with bedrock (this took me a hour to find the simple line XD)
The text was updated successfully, but these errors were encountered: